[receiver/dockerstats] Fix ToMetricLabels behaviour #21160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there some other work needed? I fear it is getting stale 😕 |
atoulme
approved these changes
May 9, 2023
atoulme
added
the
ready to merge
|
I am rerunning your failing test run, approved and marked the PR as ready to merge. |
Only one label/envVar was added even if multiple ones were specified by ContainerLabelsToMetricLabels or EnvVarsToMetricLabels. Adding a local variable shadowing the loop one solves the issue. Signed-off-by: paologallinaharbur <paologallina1992@gmail.com>
paologallinaharbur
force-pushed
the
fix/ToMetricLabels
branch
from
ec5730f
to
db08c45
Compare
|
Thanks, @atoulme, I force-pushed to rebase and trigger tests execution again, but I've not changed the code. |
codeboten
approved these changes
May 15, 2023
varunraiko
pushed a commit
to varunraiko/opentelemetry-collector-contrib
that referenced
this pull request
May 17, 2023
…1160) Only one label/envVar was added even if multiple ones were specified by ContainerLabelsToMetricLabels or EnvVarsToMetricLabels. Adding a local variable shadowing the loop one solves the issue. Signed-off-by: paologallinaharbur <paologallina1992@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Only one label/envVar was added even if multiple ones were specified
by ContainerLabelsToMetricLabels or EnvVarsToMetricLabels.
Adding a local variable shadowing the loop one solves the issue.
Without such fix the
labelvariable assumes the value of the last element computed in the loop.More details can be find reading #21113
Link to tracking Issue:
Fix #21113
Testing:
The tests that were already existing have been updated to cover the broken use-case