[cmd/mdatagen] Don't expose empty resource_attributes config section
#21519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
djaglowski,
codeboten and
MovieStoreGuy
as code owners
github-actions
bot
added
cmd/mdatagen
dmitryax
force-pushed
the
dont-generate-resource-attributes-conifg-field
branch
2 times, most recently
from
d58a457
to
7dac187
Compare
github-actions
bot
added
receiver/nsxt
github-actions
bot
requested review from
antonblock,
armstrmi,
cpheps,
crobert-1,
dehaansa,
JonathanWamsley,
Mrod1598,
nslaughter,
rmfitzpatrick,
schmikei,
shalper2 and
StefanKurek
If no resource_attributes defined in the metadata.yaml file, don't expose the corresponding empty config section and don't render unnecessary resource attributes related code.
dmitryax
force-pushed
the
dont-generate-resource-attributes-conifg-field
branch
from
7dac187
to
4194dda
Compare
MovieStoreGuy
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no
resource_attributesdefined in the metadata.yaml file, don't expose the corresponding empty user config section, and don't render unnecessary resource attributes code.