Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of JSON data sent via HEC #2159

Merged
merged 1 commit into from Jan 22, 2021

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 20, 2021

Description:
Handle cases where the time field of HEC events is encoded as a String

Link to tracking Issue:
#2158

Testing:
Unit tests

@atoulme atoulme requested a review from a team as a code owner January 20, 2021 23:43
@project-bot project-bot bot added this to In progress in Collector Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #2159 (35b5979) into master (834ec70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2159   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         397      397           
  Lines       19495    19523   +28     
=======================================
+ Hits        17620    17646   +26     
- Misses       1410     1411    +1     
- Partials      465      466    +1     
Flag Coverage Δ
integration 69.75% <ø> (+0.06%) ⬆️
unit 89.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/splunk/common.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834ec70...35b5979. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Jan 22, 2021
@tigrannajaryan tigrannajaryan merged commit 5ea1c2d into open-telemetry:master Jan 22, 2021
Collector automation moved this from Reviewer approved to Done Jan 22, 2021
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants