Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/filter] Fix HasAttributeKeyOnDatapointFactory arg type #22057

Merged
merged 3 commits into from
May 18, 2023
Merged

[processor/filter] Fix HasAttributeKeyOnDatapointFactory arg type #22057

merged 3 commits into from
May 18, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Fixes bug where HasAttributeKeyOnDatapoint was not useable because it asserted the incorrect argument type in the factory.

Testing:
Added new unit tests

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner May 17, 2023 21:56
@github-actions github-actions bot added the processor/filter Filter processor label May 17, 2023
evan-bradley
evan-bradley approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this.

processor/filterprocessor/metrics_test.go Outdated Show resolved Hide resolved
@TylerHelmuth @evan-bradley
Update processor/filterprocessor/metrics_test.go
e66ea6b 
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label May 18, 2023
@TylerHelmuth TylerHelmuth merged commit ef07a3c into open-telemetry:main May 18, 2023
88 of 89 checks passed
@TylerHelmuth TylerHelmuth deleted the fp-fix-HasAttributeKeyOnDatapointFactory branch May 18, 2023 16:35
@github-actions github-actions bot added this to the next release milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@boostchicken boostchicken Awaiting requested review from boostchicken

Assignees

@jpkrohling jpkrohling

Labels
processor/filter Filter processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TylerHelmuth @evan-bradley @jpkrohling