Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/servicegraph] use generated status header #22097

Merged
merged 3 commits into from
May 20, 2023
Merged

[processor/servicegraph] use generated status header #22097

merged 3 commits into from
May 20, 2023

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented May 19, 2023 •
edited
Loading

Description: This PR updates the component to generate the status table using mdatagen.

Link to tracking Issue: #21213 #19172

Testing:

Documentation:

@JaredTan95 JaredTan95 requested review from a team and jpkrohling as code owners May 19, 2023 08:19
@github-actions github-actions bot added the processor/servicegraph Service graph processor label May 19, 2023
@github-actions github-actions bot requested a review from mapno May 19, 2023 08:19
@JaredTan95 JaredTan95 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 19, 2023
@JaredTan95
use generated status header
d3f3204 
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@codeboten
Copy link
Contributor

import order needs fixing:

"github.com/open-telemetry/opentelemetry-collector-contrib/processor/servicegraphprocessor/internal/metadata"
156
factory.go:16: File is not `gci`-ed with --skip-generated -s standard,default,prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
157
	"go.opentelemetry.io/collector/processor"
158
metrics.go:7: File is not `gci`-ed with --skip-generated -s standard,default,prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
159
	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/servicegraphprocessor/internal/metadata"
[160](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5023296844/jobs/9007744195?pr=22097#step:8:161)
factory.go:10: File is not `goimports`-ed with -local github.com/open-telemetry/opentelemetry-collector-contrib (goimports)
[161](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5023296844/jobs/9007744195?pr=22097#step:8:162)

[162](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5023296844/jobs/9007744195?pr=22097#step:8:163)
config_test.go:11: File is not `goimports`-ed with -local github.com/open-telemetry/opentelemetry-collector-contrib (goimports)

@JaredTan95
fix fmt
824907d 
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@JaredTan95
Copy link
Member Author

import order needs fixing:

"github.com/open-telemetry/opentelemetry-collector-contrib/processor/servicegraphprocessor/internal/metadata"
156
factory.go:16: File is not `gci`-ed with --skip-generated -s standard,default,prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
157
	"go.opentelemetry.io/collector/processor"
158
metrics.go:7: File is not `gci`-ed with --skip-generated -s standard,default,prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
159
	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/servicegraphprocessor/internal/metadata"
[160](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5023296844/jobs/9007744195?pr=22097#step:8:161)
factory.go:10: File is not `goimports`-ed with -local github.com/open-telemetry/opentelemetry-collector-contrib (goimports)
[161](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5023296844/jobs/9007744195?pr=22097#step:8:162)

[162](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5023296844/jobs/9007744195?pr=22097#step:8:163)
config_test.go:11: File is not `goimports`-ed with -local github.com/open-telemetry/opentelemetry-collector-contrib (goimports)

thx, done.

@JaredTan95
fix lint
a3e2d25 
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@codeboten codeboten merged commit 69549c9 into open-telemetry:main May 20, 2023
85 checks passed
@github-actions github-actions bot added this to the next release milestone May 20, 2023
@JaredTan95 JaredTan95 deleted the servicegraph branch May 20, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@mapno mapno Awaiting requested review from mapno

Assignees

@TylerHelmuth TylerHelmuth

Labels
processor/servicegraph Service graph processor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JaredTan95 @codeboten @TylerHelmuth