[pkg/ottl] Add log body indexing #22102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
a team,
TylerHelmuth and
bogdandrutu
as code owners
TylerHelmuth
approved these changes
May 23, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow indexing slice and map log bodies. I also added the ability to get/set indices in slice-typed paths since that was required for this.
Link to tracking Issue:
Resolves #17396
Partially resolves #22068
Testing:
I tested the config in #22068 and added unit tests, which I think have pretty good coverage of the changes.
Documentation:
Updated the ottllog context readme to call out indexing support for log bodies.