[receiver/prometheus] Don't drop Histograms without buckets #23448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dashpole
reviewed
Jul 12, 2023
swiatekm
force-pushed
the
fix/prometheusreceiver/empty-histogram
branch
2 times, most recently
from
7739331
to
e2eb25c
Compare
|
I've changed the logic so we ignore the +Inf bucket and always emit at least one Otel bucket based on the total count. I tried to make the logic clearer, but not sure if this is any better in the end. Let me know what you think. |
swiatekm
force-pushed
the
fix/prometheusreceiver/empty-histogram
branch
from
e2eb25c
to
a2d36ad
Compare
swiatekm
force-pushed
the
fix/prometheusreceiver/empty-histogram
branch
from
a2d36ad
to
e2b9bb9
Compare
atoulme
added
the
ready to merge
atoulme
approved these changes
Jul 25, 2023
|
This broke unit tests on main, so I am reverting, see #24766. If you have a quick fix @swiatekm-sumo please share it with me and we can get it merged instead :) |
|
Looks like this is because the original change wasn't rebased on #24032, which moved a bunch of tests around. Should be an easy fix. |
djaglowski
pushed a commit
that referenced
this pull request
Aug 1, 2023
Fixes a failing test from #23448, which wasn't rebased on #24032 before merging. #24032 reorganized prometheus receiver tests for compliance with the openmetrics spec, and in particular made a distinction between data which Prometheus itself accepts, but the receiver doesn't, and data which neither accept. The failing test checks a histogram which wasn't accepted before #23448, but should be accepted now, and this is an intentional consequence of this change. This histogram has a bucket with an invalid label, which is quietly dropped as a result of #24032, but a valid `count`, which makes it a valid histogram due to #23448. This change basically moves the test from the `invalid` group to the `valid` group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prometheus receiver currently drops Histograms without any buckets. These are, however, explicitly allowed by the Otel spec, and can be quite useful. This change allows ingesting them. When we do so, we add an additional bucket at +Inf equal to the
countattribute of the Histogram.Link to tracking Issue: #22070
Testing:
Modified existing tests.