Add kubelet stats receiver #237
Conversation
| func (f Factory) CreateDefaultConfig() configmodels.Receiver { | ||
| return &Config{ | ||
| ReceiverSettings: configmodels.ReceiverSettings{ | ||
| TypeVal: typeStr, // TODO who tf uses this? |
There was a problem hiding this comment.
It's not except for tests that expect CreateDefaultConfig() to be equal to loading an empty receiver from a config file. I'm trying to get rid of it open-telemetry/opentelemetry-collector#971
There was a problem hiding this comment.
Ah, thanks. (this was meant be a comment for myself which I forgot to remove)
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 77.84% 77.99% +0.14%
==========================================
Files 126 142 +16
Lines 6528 6862 +334
==========================================
+ Hits 5082 5352 +270
- Misses 1166 1218 +52
- Partials 280 292 +12
Continue to review full report at Codecov.
|
go.sum
Outdated
| @@ -922,6 +923,8 @@ github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7J | |||
| github.com/onsi/gomega v1.8.1/go.mod h1:Ho0h+IUsWyvy1OpqCwxlQ/21gkhVunqlU8fDGcoTdcA= | |||
| github.com/onsi/gomega v1.9.0 h1:R1uwffexN6Pr340GtYRIdZmAiN4J+iw6WG4wog1DUXg= | |||
| github.com/onsi/gomega v1.9.0/go.mod h1:Ho0h+IUsWyvy1OpqCwxlQ/21gkhVunqlU8fDGcoTdcA= | |||
| github.com/open-telemetry/opentelemetry-collector v0.3.1-0.20200424155504-9d16f5971ef9 h1:maf2tPAv8QV17gSAePuzREqKvConQ+ozOkNM0pFgbyA= | |||
There was a problem hiding this comment.
Please rebase from master and run make gotidy
| ca_cert_path: "/path/to/ca.crt" | ||
| client_key_path: "/path/to/apiserver.key" | ||
| client_cert_path: "/path/to/apiserver.crt" |
There was a problem hiding this comment.
There is an upcoming change that uses different key names for client configs: https://github.com/open-telemetry/opentelemetry-collector/pull/988/files/405db7ad13c8feeaeb65142081b04b48e407eaf6#diff-b99ea1d4f9c67b0e6a0dc0199de54d66
It may be useful for you to sync with @ccaraman on this. For now you can probably just use the same field names to avoid breaking changes later once @ccaraman change is merged.
There was a problem hiding this comment.
Using the same field names for now. Thanks.
| cfg configmodels.Receiver, | ||
| nextConsumer consumer.TraceConsumerOld, | ||
| ) (component.TraceReceiver, error) { | ||
| return nil, nil |
There was a problem hiding this comment.
This should return configerror.ErrDataTypeIsNotSupported.
Please see README for details.
Update tls config field names, update go.mod, return appropriate error for create trace receiver.
|
@pmcollins please fix the coverage checks. |
|
@pmcollins please fix the build. |
Code coverage was failing the previous version because of lack of tests of client code. Previous client implementation was copied from smart agent with several modifications and was not as easy to test since it did network and file I/O. This change makes I/O code replaceable making Client easier to test. Additionally, ServiceAccount auth has been removed because I wasn't able to end-to-end test it due to Minikube config issues. It will be added in a separate PR.
The Kubelet Stats Receiver pulls pod metrics from the API server on a kubelet and sends it down the metric pipeline for further processing.
* Remove extraneous space in docker command * Change filename to match sample in /examples/demotrace/
* Jaeger exporter should be its own go module open-telemetry/opentelemetry-go#205 * fix review comments and build #205 * resolve mod conflicts #205
Bumps [github.com/antonmedv/expr](https://github.com/antonmedv/expr) from 1.8.9 to 1.9.0. - [Release notes](https://github.com/antonmedv/expr/releases) - [Commits](expr-lang/expr@v1.8.9...v1.9.0) --- updated-dependencies: - dependency-name: github.com/antonmedv/expr dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Please see README for details.