Add deprecation note to Dynatrace metrics exporter #23992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
requested review from
a team,
arminru and
evan-bradley
as code owners
arminru
reviewed
Jul 5, 2023
arminru
changed the title
mviitane
approved these changes
Jul 5, 2023
codeboten
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Thanks @joaopgrassi! Please add a changelog notice to notify end-users of the deprecation
|
@codeboten added the changelog entry! |
codeboten
reviewed
Jul 5, 2023
|
@codeboten ah thanks for the pointer, done! We are not ready to remove it completely, so I added the similar wording as we have in the readme for now. I hope that is OK :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Dynatrace has support for ingesting traces, metrics and logs via OTLP, so the custom metrics exporter is not needed anymore. This PR adds a deprecation message about it as well as other minor wording/improvements.
Link to tracking Issue:
N/A
Testing:
N/A
Documentation:
Exporter readme updated.