[receiver/kubeletstatsreceiver] prepend container. metrics with k8s. #24388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces `k8s.container*` metrics, which will replace their `container.*` metrics counterparts. For now, the `k8s.container*` metrics are disabled by default. The following process will be followed to phase out the old metrics: - In `v0.82.0`, the new metric is introduced and the old metric is marked as deprecated. Only the old metric are emitted by default. - In `v0.84.0`, the old metric is disabled and the new one enabled by default. - In `v0.86.0` and up, the old metric is removed. Please refer to the following issue: open-telemetry#24238 for the reason for this change.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces
k8s.container*metrics, which will replace theircontainer.*metrics counterparts. For now, thek8s.container*metrics are disabled by default.The following process will be followed to phase out the old metrics:
v0.82.0, the new metric is introduced and the old metric is marked as deprecated. Only the old metric are emitted by default.v0.84.0, the old metric is disabled and the new one enabled by default.v0.86.0and up, the old metric is removed.Please refer to the following issue: #24238 for the reason for this change.
Link to tracking Issue:
#24238