[exporter/mezmoexporter] unexport mezmo structs #24842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Aug 3, 2023
|
After merging few similar PRs, I released that these are breaking api changes. Given that we now have a separate changelog for API, we should utilize it. @atoulme can you please add changelog entry for this one and for others? |
|
This one needs a changelog for sure. Do we need it for others where it's only test code? |
atoulme
changed the title
dashpole
approved these changes
Aug 3, 2023
Technically yes. They can potentially still be used outside. |
dmitryax
approved these changes
Aug 3, 2023
|
Alright I will create a separate PR for all the changelogs I missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those structs don't need to be exported as part of the Go API.