Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky TestScopeInfoScopeAttributes unit test #26240

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix flaky TestScopeInfoScopeAttributes unit test #26240

merged 2 commits into from
Aug 28, 2023

Conversation

dashpole
Copy link
Contributor

Description:

Fixes #26123

It sorts scopes before checking them.

@crobert-1

@dashpole dashpole requested review from Aneurysm9 and a team as code owners August 28, 2023 19:10
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 28, 2023
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Aug 28, 2023
@crobert-1
Copy link
Member

Failing integration test is frequency of #26097, unrelated to this change.

@dmitryax dmitryax merged commit 781575d into open-telemetry:main Aug 28, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@codeboten codeboten

Labels
receiver/prometheus Prometheus receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.84.0
Development

Successfully merging this pull request may close these issues.

[receiver/prometheus] Unit test failure: TestScopeInfoScopeAttributes
4 participants
@dashpole @crobert-1 @dmitryax @codeboten