Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/storage/filestorage] Add bbolt FSync as a config option #27459

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

natbur
Copy link
Contributor

@natbur natbur commented Oct 6, 2023

Description: Exposes bbolt fsync as a configuration option

Link to tracking Issue: 20266

Testing: Manual Testing, Updated unit tests for factory and client

Documentation: Added change-log and documentation comments in config.go

@natbur natbur requested review from djaglowski and a team as code owners October 6, 2023 03:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @natbur.

This looks good to me. However, we'll need accompanying documentation changes. Do you mind updating the readme to include an explanation of the parameter?

@natbur
Copy link
Contributor Author

natbur commented Oct 11, 2023

Readme updated

@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Oct 12, 2023
@djaglowski djaglowski merged commit 6e02e73 into open-telemetry:main Oct 13, 2023
96 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 13, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
…pen-telemetry#27459)

Description: Exposes bbolt fsync as a configuration option

Link to tracking Issue:
[20266](open-telemetry#20266)

Testing: Manual Testing, Updated unit tests for factory and client

Documentation: Added change-log and documentation comments in config.go

---------

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…pen-telemetry#27459)

Description: Exposes bbolt fsync as a configuration option

Link to tracking Issue:
[20266](open-telemetry#20266)

Testing: Manual Testing, Updated unit tests for factory and client

Documentation: Added change-log and documentation comments in config.go

---------

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/storage Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants