[pkg/stanza] Cache event publishers: log warn once per provider #27658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
changed the title
djaglowski
reviewed
Oct 12, 2023
|
@pjanotti, thanks for the work on this. You appear to have a lot more expertise than I on the details of WEL. Are you interested in being a code owner on this component? (I'm happy to stay on to help with general issues relating to |
|
@djaglowski, yes, I'm interested on that. I'm planning to focus on Windows related stuff in general. The package is pretty big and it will take some time for me to get used to it, but, let's get started. |
|
Thanks @pjanotti. Please submit a PR to add yourself as an owner. This PR looks good to me. I think we just need a changelog. |
djaglowski
approved these changes
Oct 13, 2023
djaglowski
pushed a commit
that referenced
this pull request
Oct 13, 2023
**Description:** Adding myself as owner of `windowseventlogreceiver` per invite #27658 (comment) cc @djaglowski
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 15, 2023
…-telemetry#27658) **Description:** Cache the publisher event to: 1. Avoid logging the same error message every time one event from the given source is logged. 2. Avoid opening and closing the event publisher for every single event. **Link to tracking Issue:** [Item 4 described on the investigation](open-telemetry#21491 (comment)) for issue open-telemetry#21491. **Testing:** * Go tests for `pkg/stanza` and `receiver/windowseventlogreceiver` on Windows box. * Ran the contrib build locally to validate the change. * Can't run the full make locally: misspell is failing on Windows because the command line is too long. **Documentation:** Let me know if changing the severity of the log message requires a changelog update.
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 15, 2023
**Description:** Adding myself as owner of `windowseventlogreceiver` per invite open-telemetry#27658 (comment) cc @djaglowski
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…-telemetry#27658) **Description:** Cache the publisher event to: 1. Avoid logging the same error message every time one event from the given source is logged. 2. Avoid opening and closing the event publisher for every single event. **Link to tracking Issue:** [Item 4 described on the investigation](open-telemetry#21491 (comment)) for issue open-telemetry#21491. **Testing:** * Go tests for `pkg/stanza` and `receiver/windowseventlogreceiver` on Windows box. * Ran the contrib build locally to validate the change. * Can't run the full make locally: misspell is failing on Windows because the command line is too long. **Documentation:** Let me know if changing the severity of the log message requires a changelog update.
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
**Description:** Adding myself as owner of `windowseventlogreceiver` per invite open-telemetry#27658 (comment) cc @djaglowski
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…-telemetry#27658) **Description:** Cache the publisher event to: 1. Avoid logging the same error message every time one event from the given source is logged. 2. Avoid opening and closing the event publisher for every single event. **Link to tracking Issue:** [Item 4 described on the investigation](open-telemetry#21491 (comment)) for issue open-telemetry#21491. **Testing:** * Go tests for `pkg/stanza` and `receiver/windowseventlogreceiver` on Windows box. * Ran the contrib build locally to validate the change. * Can't run the full make locally: misspell is failing on Windows because the command line is too long. **Documentation:** Let me know if changing the severity of the log message requires a changelog update.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Adding myself as owner of `windowseventlogreceiver` per invite open-telemetry#27658 (comment) cc @djaglowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cache the publisher event to:
Link to tracking Issue:
Item 4 described on the investigation for issue #21491.
Testing:
pkg/stanzaandreceiver/windowseventlogreceiveron Windows box.Documentation:
Let me know if changing the severity of the log message requires a changelog update.