[processors/resourcedetection] Add missing entries for cloud.infrastructure_service
#2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructure_service` This adds missing `cloud.infrastructure_service` for ec2, gcp, and azure. The docs were corrected for AWS services to reflect what the code was already doing. Detectors for gke and eks will be added in a following PR. Those detectors will add their own service-specific `cloud.infrastructure_service`.
dmitryax
approved these changes
Mar 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
- Coverage 91.56% 91.56% -0.01%
==========================================
Files 447 447
Lines 22056 22058 +2
==========================================
+ Hits 20196 20197 +1
- Misses 1391 1392 +1
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Aneurysm9
approved these changes
Mar 19, 2021
mx-psi
approved these changes
Mar 19, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…ructure_service` (#2777) This adds missing `cloud.infrastructure_service` for ec2, gcp, and azure. The docs were corrected for AWS services to reflect what the code was already doing. Detectors for gke and eks will be added in a following PR. Those detectors will add their own service-specific `cloud.infrastructure_service`.
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing
cloud.infrastructure_servicefor ec2, gcp, and azure. Thedocs were corrected for AWS services to reflect what the code was already
doing.
Detectors for gke and eks will be added in a following PR. Those detectors will
add their own service-specific
cloud.infrastructure_service.