Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to filter and export markers #27862

Merged
merged 46 commits into from
Nov 16, 2023

Conversation

fchikwekwe
Copy link
Contributor

@fchikwekwe fchikwekwe commented Oct 19, 2023

Description: This add logic to filter logs based on log conditions and sent desired logs as event markers to the honeycomb marker api.

Link to tracking Issue: #27666

Testing: Unit testing for log exporter and config. Added component testing to otelcontribcol.

Documentation: README describing component usage

Screenshot of exported markers showing up in Honeycomb
Screenshot 2023-11-14 at 1 27 49 PM

@fchikwekwe fchikwekwe marked this pull request as ready for review October 30, 2023 16:32
@fchikwekwe fchikwekwe requested a review from a team as a code owner October 30, 2023 16:32
@fchikwekwe fchikwekwe changed the title Feat/hny marker exporter feat: add ability to filter and export markers Nov 2, 2023
@TylerHelmuth TylerHelmuth added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Nov 14, 2023
exporter/honeycombmarkerexporter/go.mod Outdated Show resolved Hide resolved
exporter/honeycombmarkerexporter/go.mod Outdated Show resolved Hide resolved
exporter/honeycombmarkerexporter/go.mod Outdated Show resolved Hide resolved
exporter/honeycombmarkerexporter/go.mod Outdated Show resolved Hide resolved
exporter/honeycombmarkerexporter/go.mod Outdated Show resolved Hide resolved
exporter/honeycombmarkerexporter/go.mod Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 01559fb into open-telemetry:main Nov 16, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 16, 2023
graphaelli pushed a commit to graphaelli/opentelemetry-collector-contrib that referenced this pull request Nov 17, 2023
**Description:** This add logic to filter logs based on log conditions
and sent desired logs as event markers to the honeycomb marker api.

**Link to tracking Issue:**
open-telemetry#27666

**Testing:** Unit testing for log exporter and config. Added component
testing to `otelcontribcol`.

**Documentation:** README describing component usage

Screenshot of exported markers showing up in Honeycomb
<img width="1225" alt="Screenshot 2023-11-14 at 1 27 49 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/35741033/128d689a-cf1e-4959-9df3-6c88248a7fdb">

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
**Description:** This add logic to filter logs based on log conditions
and sent desired logs as event markers to the honeycomb marker api.

**Link to tracking Issue:**
open-telemetry#27666

**Testing:** Unit testing for log exporter and config. Added component
testing to `otelcontribcol`.

**Documentation:** README describing component usage

Screenshot of exported markers showing up in Honeycomb
<img width="1225" alt="Screenshot 2023-11-14 at 1 27 49 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/35741033/128d689a-cf1e-4959-9df3-6c88248a7fdb">

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command exporter/honeycombmarker Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants