[kafkareceiver] Add Azure Resource Log Support #28626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cparkins
requested review from
MovieStoreGuy,
a team and
atoulme
as code owners
6 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
cparkins
requested review from
jpkrohling,
dmitryax,
TylerHelmuth,
mx-psi and
codeboten
as code owners
github-actions
bot
added
cmd/telemetrygen
github-actions
bot
added
receiver/opencensus
receiver/skywalking
and removed
Stale
labels
|
@cparkins can you update to Go 1.21 and run |
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
3cffc47
to
8988316
Compare
github-actions
bot
added
the
processor/resourcedetection
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
2f08c58
to
5e53194
Compare
|
@mx-psi I've rebased to remove the modifications made by running make gotidy. |
mx-psi
reviewed
Nov 22, 2023
| "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/azure" | ||
| ) | ||
|
|
||
| type AzureResourceLogsUnmarshaler struct { |
There was a problem hiding this comment.
This should not be exported
Suggested change
| type AzureResourceLogsUnmarshaler struct { | |
| type azureResourceLogsUnmarshaler struct { |
receiver/kafkareceiver/README.md
Outdated
| @@ -42,6 +42,7 @@ The following settings can be optionally configured: | |||
| - `raw`: (logs only) the payload's bytes are inserted as the body of a log record. | |||
| - `text`: (logs only) the payload are decoded as text and inserted as the body of a log record. By default, it uses UTF-8 to decode. You can use `text_<ENCODING>`, like `text_utf-8`, `text_shift_jis`, etc., to customize this behavior. | |||
| - `json`: (logs only) the payload is decoded as JSON and inserted as the body of a log record. | |||
| - `azureresourcelogs`: (logs only) the payload is converted from Azure Resource Logs format to OTel format. | |||
There was a problem hiding this comment.
Should this be azure_resource_logs instead for consistency in the casing style?
mx-psi
approved these changes
Dec 7, 2023
jayasai470
pushed a commit
to jayasai470/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2023
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add support for the Azure Resource Log format so that Diagnostic logs from Azure can be consumed by a Kafka Receiver. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#18210 **Testing:** <Describe what testing was performed and which tests were added.> Local testing to ensure that data is being converted correctly when Streaming from Azure Diagnostic Settings to Event Hubs and using the Kafka Receiver. **Documentation:** <Describe the documentation added.> Added a bullet for the added azure format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for the Azure Resource Log format so that Diagnostic logs from Azure can be consumed by a Kafka Receiver.
Link to tracking Issue:
#18210
Testing:
Local testing to ensure that data is being converted correctly when Streaming from Azure Diagnostic Settings to Event Hubs and using the Kafka Receiver.
Documentation:
Added a bullet for the added azure format.