add instrumentation.provider to newrelic default attrs #2900
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2900 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 463 463
Lines 22779 22780 +1
=======================================
+ Hits 20853 20854 +1
Misses 1435 1435
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| "collector.name": name, | ||
| "collector.version": version, | ||
| "name": "root", | ||
| instrumentationProviderAttrKey: "opentelemetry", |
There was a problem hiding this comment.
I would stick with string to make the test easier to read without having to double check against the code. Otherwise, let's update the other keys to use the variables - mixing strings and variables looks a bit odd.
There was a problem hiding this comment.
Good point, I'll revert the key to string.
|
Hi @gunturaf , thanks for the PR! I'm checking with our UI folks right now. We were supposed to have removed the requirement on |
|
Yup looks like it's currently needed. |
…y#2900) * add instrumentation.provider to newrelic default attrs * use string instead of variables for keys in test
Allows Summary metrics to be exported to Prometheus. To walk through this feature, I created an adaptation of a Brian Brazil tutorial for DropWizard, to create a Java server at https://github.com/odeke-em/bugs/tree/master/opentelemetry-collector/2661 and it uses DropWizard, and exports out JVM statistics with Prometheus where the *gc_collection_seconds are of the summary kind when scraped by visiting http://localhost:1234/metrics which produced ``` # HELP jvm_gc_collection_seconds Time spent in a given JVM garbage collector in seconds. # TYPE jvm_gc_collection_seconds summary jvm_gc_collection_seconds_count{gc="G1 Young Generation",} 4.0 jvm_gc_collection_seconds_sum{gc="G1 Young Generation",} 0.026 jvm_gc_collection_seconds_count{gc="G1 Old Generation",} 0.0 ``` and then roundtripped the collector to scrape those metrics and then export them to Prometheus VS making Prometheus directly scrape that endpoint and then comparing results. Also added an end to end test to ensure that a mock DropWizard server which produces JVM statistics can be scraped by the Prometheus receiver, which will feed metrics to an active Prometheus exporter, and then we scrape from the Prometheus exporter to ensure that the summary metrics are written out and that they make sense. DropWizard -> Prometheus Receiver -> Prometheus Exporter -> HTTP scrape + Verify Fixes #2661
* add instrumentation.provider to newrelic default attrs * use string instead of variables for keys in test
Description:
Add
instrumentation.provider = opentelemetryto exported attributesLink to tracking Issue: #2621
Testing: updated
newrelic_test.goandtransformer_test.goDocumentation: