Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [reveiver/prometheusreceiver] Add unit tests around protobuf negotiation #29153

Merged
merged 11 commits into from
Nov 15, 2023
Merged

[chore] [reveiver/prometheusreceiver] Add unit tests around protobuf negotiation #29153

merged 11 commits into from
Nov 15, 2023

Commits on Nov 13, 2023

  1. Refactor testComponent signature 

    I want to get access to EnableProtobufNegotiation

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    eedac90 View commit details
    Browse the repository at this point in the history

  2. First iteration on unit test for protobuf scraping 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    be2490f View commit details
    Browse the repository at this point in the history

  3. Refactor for reuse 

    Move prom metric family to protobuf encoding to its own function.
Reuse assertMetricPresent

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    bc5e5f3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into promreceiver-unit-test-protobuf

    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0cb6476 View commit details
    Browse the repository at this point in the history

  5. Add summary and histogram to protobuf test 

    Also assert on explicit bounds.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    07af8a7 View commit details
    Browse the repository at this point in the history

  6. Fix imports lint 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    452a883 View commit details
    Browse the repository at this point in the history

  7. Fix TestMetricNormalize 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a231f9d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Remove redundant comment 

    Code should be clear enough now.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    44c548f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into promreceiver-unit-test-protobuf

    @krajorama
    krajorama committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5d73d42 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into promreceiver-unit-test-protobuf

    @krajorama
    krajorama committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    57135f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge branch 'main' into promreceiver-unit-test-protobuf

    @dashpole
    dashpole committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    02057bd View commit details
    Browse the repository at this point in the history