-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.github] Simplify workflow #29286
[.github] Simplify workflow #29286
Conversation
8e3075c
to
14509d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't recall these checks ever revealing anything actionable, so fully agree with them being removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installation of the deb/rpm packages has definitely caught issues in the past where the service would fail to start. I'd recommend adding a similar test somewhere if we don't want the checks here. Pinging @atoulme who reminded me of this on another issue where i suggested the same thing
Shouldn't this be covered by e2e tests? It doesn't make a lot of sense to me to build a deb/rpm that we never end up using just for this. |
Sure, I don't know if it's possible to run the installation test without an installable package :) This might be a chicken and egg problem. I'm in support of adding these tests where it makes sense, I just don't want to lose the ability to test for regressions |
Ahhh, so you are talking about the systemd service, not the Collector service (as in, I guess then my question is... is the systemd service on this repository consistent with the systemd service on releases? Do we have any automated way of making sure they keep on being consistent over time? I am tempted to close this and file an issue on releases to add these tests there, since that seems like the right place to test things in (with the final artifacts that we actually release to users). Would that make sense to you? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closing in favor of open-telemetry/opentelemetry-collector-releases/issues/439 |
Description:
I think we can get rid of these jobs, since the
deb
s andrpm
s are created in opentelemetry-collector-releases.