[exporter/honeycombmarker] Fix default url and dataset_slug #29309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
force-pushed
the
honeycombmarker-fix-url-bug
branch
from
2c5adce
to
df1552e
Compare
TylerHelmuth
added
the
ready to merge
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…emetry#29309) **Description:** Fixes an issue with an incorrect default url. Also fixes issue where dataset slug was required. **Link to tracking Issue:** <Issue number if applicable> Related to open-telemetry#27666 **Testing:** <Describe what testing was performed and which tests were added.> Added new tests and tested manually. **Documentation:** <Describe the documentation added.> Updated up README
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…emetry#29309) **Description:** Fixes an issue with an incorrect default url. Also fixes issue where dataset slug was required. **Link to tracking Issue:** <Issue number if applicable> Related to open-telemetry#27666 **Testing:** <Describe what testing was performed and which tests were added.> Added new tests and tested manually. **Documentation:** <Describe the documentation added.> Updated up README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue with an incorrect default url. Also fixes issue where dataset slug was required.
Link to tracking Issue:
Related to #27666
Testing:
Added new tests and tested manually.
Documentation:
Updated up README