Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [pkg/resourcetotelemetry] reduce memory usage #29327

Merged
merged 2 commits into from
Nov 24, 2023
Merged

[chore] [pkg/resourcetotelemetry] reduce memory usage #29327

merged 2 commits into from
Nov 24, 2023

Conversation

philchia
Copy link
Contributor

@philchia philchia commented Nov 17, 2023 •
edited

Description:

  1. Reduce memory usage by modify data in place, just let the pipeline builder to determine whether or not to clone data.

Link to tracking Issue:

N/A

Testing:

N/A

Documentation:

N/A

@philchia philchia requested review from mx-psi and a team as code owners November 17, 2023 14:22
@philchia philchia force-pushed the optimize-resource-to-telemetry branch from 3a0150e to 2c82820 Compare November 17, 2023 14:29
@philchia philchia changed the title [chore] [exporter/prometheusremotewrite] reduce memory usage [chore] [pkg/resourcetotelemetry] reduce memory usage Nov 17, 2023
@philchia philchia force-pushed the optimize-resource-to-telemetry branch from 30b68ae to 4a66cd0 Compare November 21, 2023 03:46
mx-psi
mx-psi approved these changes Nov 21, 2023
View reviewed changes
.chloggen/optimize-resource-to-telemetry.yaml Outdated Show resolved Hide resolved
philchia and others added 2 commits November 22, 2023 11:02
@philchia @mx-psi
[chore] [exporter/prometheusremotewrite] reduce memory usage by preve…
b72e3da 
…nt clone data

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@philchia @mx-psi
Update .chloggen/optimize-resource-to-telemetry.yaml
0d506cd 
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@philchia philchia force-pushed the optimize-resource-to-telemetry branch from 3992b8d to 0d506cd Compare November 22, 2023 03:02
@mx-psi mx-psi requested a review from atoulme November 22, 2023 10:24
@mx-psi mx-psi merged commit 3cedb23 into open-telemetry:main Nov 24, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees

@fatsheep9146 fatsheep9146

Labels
pkg/resourcetotelemetry
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philchia @atoulme @mx-psi @fatsheep9146