Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/influxdbreceiver] Add the /ping endpoint for enhanced compatibility #29662

Merged

Conversation

jve-engineering
Copy link
Contributor

Description: This PR supplements the receiver influxdbreceiver with an implementation of the /ping endpoint. Various third-party applications use this to check the availability of the receiver before sending metrics, e.g. checkmk.

Link to tracking Issue: #29594

Testing: Basic tests and end to end testing with the third party application checkmk.

Documentation: No additional documentation has been added.

  • The user does not interact directly with this endpoint.
  • There are no configuration options.

- This minimal implementation always responds with HTTP Status 204
- Response headers are not included
- Based on the [InfluxDB v2 API documentation](https://docs.influxdata.com/influxdb/v2/api/#operation/GetPing)
- End to end tested with [Checkmk Cloud Edition 2.2.0p14](https://checkmk.com/product/cloud-edition)
@jve-engineering jve-engineering requested a review from a team as a code owner December 5, 2023 19:52
Copy link

linux-foundation-easycla bot commented Dec 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@crobert-1 crobert-1 added the enhancement New feature or request label Dec 6, 2023
@mx-psi
Copy link
Member

mx-psi commented Dec 7, 2023

@jacobmarble PTAL as the codeowner of this component!

Copy link
Contributor

@jacobmarble jacobmarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet and simple. Thanks @jve-engineering

@mx-psi mx-psi merged commit 5b66f0e into open-telemetry:main Dec 11, 2023
79 of 83 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/influxdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants