[cmd/telemetrygen] Add TLS/mTLS support to telemetrygen #29681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Dec 7, 2023
mx-psi
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks for the PR! Some notes:
- Let's move the timeout functionality to a different PR since this is separate and we can discuss there in detail
- If you want to add examples, they need to be tested on CI to ensure we don't break them
- The current implementation is specific to traces. I think we can add it for all signals instead
Juliaj
force-pushed
the
telemetrygen_tls_secure_tracing
branch
from
914c85a
to
fd55b0a
Compare
Juliaj
changed the title
mx-psi
reviewed
Jan 4, 2024
Juliaj
force-pushed
the
telemetrygen_tls_secure_tracing
branch
from
f9e0e89
to
bd24163
Compare
mx-psi
reviewed
Jan 5, 2024
Juliaj
force-pushed
the
telemetrygen_tls_secure_tracing
branch
from
2981d2c
to
3a74ad7
Compare
mx-psi
approved these changes
Jan 8, 2024
|
#29681 (comment) was hidden, it's only a nit so please only address if you think it makes sense :) |
Juliaj
force-pushed
the
telemetrygen_tls_secure_tracing
branch
from
f6556ba
to
9b51aab
Compare
Juliaj
force-pushed
the
telemetrygen_tls_secure_tracing
branch
from
f65ff8c
to
2ed169d
Compare
Thanks for the suggestion. Updated. |
mx-psi
approved these changes
Jan 10, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…ry#29681) **Description:** Implementing robust security measures is essential for any tracing ingestion service and infrastructure. This adds TLS/mTLS support to telemetrygen traces so that it can be used to test the security implementation. To illustrate the usage, a new example, `secure-tracing` is added to examples collection. **Link to tracking Issue:** <Issue number if applicable> **Testing:** Tested with the `secure-tracing` example. **Documentation:** - telemetrygen README has been updated with a link to secure-tracing. - secure-tracing README contains setup of a testing environment and test script via telemetrygen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implementing robust security measures is essential for any tracing ingestion service and infrastructure. This adds TLS/mTLS support to telemetrygen traces so that it can be used to test the security implementation. To illustrate the usage, a new example,
secure-tracingis added to examples collection.Link to tracking Issue:
Testing:
Tested with the
secure-tracingexample.Documentation: