[opampsupervisor] fix panic on shutdown #29955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
evan-bradley,
tigrannajaryan and
a team
as code owners
atoulme
force-pushed
the
fix_panic_supervisor
branch
from
600021a
to
350ec20
Compare
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
**Description:** Fixes panic reported in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950 ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x8d5d84] goroutine 49 [running]: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander.(*Commander).Stop.func1() /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander/commander.go:157 +0x1e4 created by github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander.(*Commander).Stop /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander/commander.go:153 +0x[21](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950#step:8:22)a exit status 2 FAIL github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor 1.520s ```
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
**Description:** Fixes panic reported in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950 ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x8d5d84] goroutine 49 [running]: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander.(*Commander).Stop.func1() /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander/commander.go:157 +0x1e4 created by github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander.(*Commander).Stop /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander/commander.go:153 +0x[21](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950#step:8:22)a exit status 2 FAIL github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor 1.520s ```
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** Fixes panic reported in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950 ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x8d5d84] goroutine 49 [running]: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander.(*Commander).Stop.func1() /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander/commander.go:157 +0x1e4 created by github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander.(*Commander).Stop /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/commander/commander.go:153 +0x[21](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950#step:8:22)a exit status 2 FAIL github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor 1.520s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes panic reported in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7236299619/job/19714748723?pr=29950