[pkg/ottl] Fix bug where IsBool wasn't usable
#30151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu,
evan-bradley and
a team
as code owners
bogdandrutu
approved these changes
Dec 21, 2023
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
TylerHelmuth
added a commit
that referenced
this pull request
Jan 8, 2024
**Description:** Adds e2e tests for OTTL functionality and all `ottlfuncs` functions. Includes the bug fix from #30151 **Link to tracking Issue:** <Issue number if applicable> Closes #28642 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Updated contributing doc
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** Adds e2e tests for OTTL functionality and all `ottlfuncs` functions. Includes the bug fix from open-telemetry#30151 **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#28642 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Updated contributing doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Found a bug where the
BoolGetterandBoolLikeGettertypes were not included in the function parser's switch statement. This meant OTTL didn't know how to interpret that parameter type which meanIsBoolis not actually usable.I missed this while reviewing #27900
Link to tracking Issue:
Found while working on #28642 - issues like these are why these e2e tests will be useful.
Testing:
Will add the e2e tests as part of #28642