[receiver/sshcheck] enable Windows #30648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
force-pushed
the
try_windows_sshcheckreceiver
branch
from
622527c
to
117bef6
Compare
atoulme
changed the title
atoulme
force-pushed
the
try_windows_sshcheckreceiver
branch
from
117bef6
to
991f821
Compare
atoulme
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
force-pushed
the
try_windows_sshcheckreceiver
branch
from
10046a7
to
0d3b3dd
Compare
|
@codeboten @nslaughter please take a look |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Still waiting for review. |
codeboten
approved these changes
Apr 19, 2024
codeboten
reviewed
Apr 22, 2024
There was a problem hiding this comment.
@atoulme the readme needs to be regenerated https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8760447193/job/24045427581?pr=30648#step:17:304
atoulme
force-pushed
the
try_windows_sshcheckreceiver
branch
from
8779750
to
6a0b14f
Compare
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
Removes the checks forbidding to use sshcheckreceiver on Windows. Fixes open-telemetry#30650 Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the checks forbidding to use sshcheckreceiver on Windows.
Fixes #30650