Remove the obsolete +build directive #30651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
djaglowski,
a team,
dashpole,
TylerHelmuth,
atoulme,
MovieStoreGuy,
Aneurysm9,
fatsheep9146,
mx-psi,
songy23,
evan-bradley and
tigrannajaryan
as code owners
github-actions
bot
added
cmd/opampsupervisor
cmd/otelcontribcol
dmitryax
force-pushed
the
remove-absolete-build-directive
branch
from
facce1a
to
25a8a8f
Compare
dmitryax
commented
Jan 17, 2024
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| semconv "go.opentelemetry.io/collector/semconv/v1.21.0" | ||
| "go.uber.org/zap" | ||
|
|
||
| "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor" | ||
| "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/config" |
There was a problem hiding this comment.
Not sure the linter wasn't complaining about it
There was a problem hiding this comment.
I believe the linter only runs against files which match certain tags. See #11557
Not sure if the new syntax is handled more appropriately but it's possible we have better coverage now.
There was a problem hiding this comment.
Probably not. This change was triggered by my IDE, not linter
songy23
approved these changes
Jan 17, 2024
TylerHelmuth
approved these changes
Jan 17, 2024
"// +build" was replaced with "//go:build" directive in 1.17. +build can be removed since we support only 1.20 and 1.21
dmitryax
force-pushed
the
remove-absolete-build-directive
branch
from
8db5c8c
to
900e5ee
Compare
mfyuce
pushed a commit
to mfyuce/opentelemetry-collector-contrib
that referenced
this pull request
Jan 18, 2024
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// +buildwas replaced with//go:builddirective in Go 1.17. +build can be removed since we support only 1.20 and 1.21Same as open-telemetry/opentelemetry-collector#9304