OpenTelemetry Protocol with Apache Arrow Receiver initial skeleton #30766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into jmacd/otelarrow_recv_skel
…tor-contrib into jmacd/otelarrow_recv_skel
jmacd
added a commit
to open-telemetry/otel-arrow
that referenced
this pull request
Jan 26, 2024
Keeping changes in sync between this repo and open-telemetry/opentelemetry-collector-contrib#30766 Remove two dead files that will be regenerated in contrib. Remove `otlpReceiver` type name, use `otelArrowReceiver`. Move sharedcomponent to internal package location.
…tor-contrib into jmacd/otelarrow_recv_skel
Signed-off-by: Joshua MacDonald <josh.macdonald@gmail.com>
Signed-off-by: Joshua MacDonald <josh.macdonald@gmail.com>
jmacd
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
atoulme,
dmitryax,
codeboten and
fatsheep9146
as code owners
|
It looks like when the base collector version is updated between releases, as has been done, it becomes difficult/impossible to create new components that will pass all the checks. The best solution I've been able to come to (since |
|
🟢 |
atoulme
reviewed
Jan 31, 2024
atoulme
reviewed
Jan 31, 2024
atoulme
reviewed
Jan 31, 2024
atoulme
approved these changes
Jan 31, 2024
…tor-contrib into jmacd/otelarrow_recv_skel
|
🟢 |
codeboten
approved these changes
Feb 7, 2024
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…pen-telemetry#30766) First PR to introduce the OpenTelemetry Protocol with Apache Arrow receiver. From the upstream repository: https://github.com/open-telemetry/otel-arrow/blob/main/collector/receiver/otelarrowreceiver. Similar to open-telemetry#30619 for the corresponding receiver. **Link to tracking Issue:** open-telemetry#26491 **Testing:** This is a skeleton PR, therefore only the skeleton contains tests. Compared with the upstream repository, the factory_test.go and config_test.go files have been kept, the implementation tests in otelarrow_test.go were excluded in this PR. **Documentation:** New README, [copied from the upstream repository](https://github.com/open-telemetry/otel-arrow/blob/main/collector/receiver/otelarrowreceiver/README.md). --------- Signed-off-by: Joshua MacDonald <josh.macdonald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
First PR to introduce the OpenTelemetry Protocol with Apache Arrow receiver. From the upstream repository: https://github.com/open-telemetry/otel-arrow/blob/main/collector/receiver/otelarrowreceiver.
Similar to #30619 for the corresponding receiver.
Link to tracking Issue: #26491
Testing:
This is a skeleton PR, therefore only the skeleton contains tests. Compared with the upstream repository, the factory_test.go and config_test.go files have been kept, the implementation tests in otelarrow_test.go were excluded in this PR.
Documentation: New README, copied from the upstream repository.