[cmd/opampsupervisor] Persist collector remote config & telemetry set… #30807
Conversation
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
| return err | ||
| } | ||
|
|
||
| return os.WriteFile(filepath.Join(s.config.Storage.Directory, lastRecvRemoteConfigFile), cfg, 0644) |
There was a problem hiding this comment.
Should we make the permissions on this file more restrictive, e.g. 0600?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…tor-contrib into issue-21078
…llector-contrib into issue-21078
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@srikanthccv Are you still working on this? I'd be happy to help push this forward. |
|
Hi @BinaryFissionGames, I am on vacation till 1st Apr. I will revive this after I come back. |
There was a problem hiding this comment.
Thanks for the continued work @srikanthccv, please resolve the conflicts. @evan-bradley if you could review, would be great to move this forward.
|
@srikanthccv FYI it looks like some conflicts were introduced by other Supervisor PRs. |
open-telemetry#30807) …tings **Description:** <Describe what has changed.> Persists the configs contained in the AgentRemoteConfig and ConnectionSettings messages to be used on startup before any messages have been received from the OpAMP server. If the capability corresponding to the message for the config is disabled, then the config is not merged into the Collector's effective configuration **Link to tracking Issue:** Part of open-telemetry#21078 **Testing:** Added e2e test **Documentation:** <Describe the documentation added.>
…tings
Description:
Persists the configs contained in the AgentRemoteConfig and ConnectionSettings messages to be used on startup before any messages have been received from the OpAMP server. If the capability corresponding to the message for the config is disabled, then the config is not merged into the Collector's effective configuration
Link to tracking Issue: Part of #21078
Testing:
Added e2e test
Documentation: