Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testbed] Deprecate testbed.GetAvailablePort #30811

Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 28, 2024

Description:
Deprecate testbed.GetAvailablePort in favor of testutil.GetAvailablePort
Move healthcheckextension to use testutil.GetAvailablePort

@atoulme atoulme requested review from a team and jpkrohling as code owners January 28, 2024 06:44
@github-actions github-actions bot added extension/healthcheck Health Check Extension testbed labels Jan 28, 2024
@atoulme atoulme force-pushed the deprecate_testbed_GetAvailablePort branch 2 times, most recently from a6719fe to 01c45fc Compare January 28, 2024 06:56
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels Jan 28, 2024
@atoulme atoulme force-pushed the deprecate_testbed_GetAvailablePort branch from 01c45fc to 8a99627 Compare January 29, 2024 06:52
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we will either need to do the deprecation on a separate PR, or fix all uses on this one

@atoulme atoulme force-pushed the deprecate_testbed_GetAvailablePort branch 2 times, most recently from 8c1888f to e847422 Compare January 30, 2024 16:11
@atoulme atoulme force-pushed the deprecate_testbed_GetAvailablePort branch from e847422 to 2fbbf1f Compare January 31, 2024 17:14
@mx-psi mx-psi merged commit ba3d660 into open-telemetry:main Jan 31, 2024
95 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 31, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
**Description:**
Deprecate testbed.GetAvailablePort in favor of testutil.GetAvailablePort
Move healthcheckextension to use testutil.GetAvailablePort
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2024
**Description:**
Deprecate testbed.GetAvailablePort in favor of testutil.GetAvailablePort
Move healthcheckextension to use testutil.GetAvailablePort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command extension/healthcheck Health Check Extension testbed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants