New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testbed] Deprecate testbed.GetAvailablePort #30811
Merged
mx-psi
merged 5 commits into
open-telemetry:main
from
atoulme:deprecate_testbed_GetAvailablePort
Jan 31, 2024
Merged
[testbed] Deprecate testbed.GetAvailablePort #30811
mx-psi
merged 5 commits into
open-telemetry:main
from
atoulme:deprecate_testbed_GetAvailablePort
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
deprecate_testbed_GetAvailablePort
branch
2 times, most recently
from
January 28, 2024 06:56
a6719fe
to
01c45fc
Compare
github-actions
bot
added
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
labels
Jan 28, 2024
atoulme
force-pushed
the
deprecate_testbed_GetAvailablePort
branch
from
January 29, 2024 06:52
01c45fc
to
8a99627
Compare
mx-psi
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we will either need to do the deprecation on a separate PR, or fix all uses on this one
atoulme
force-pushed
the
deprecate_testbed_GetAvailablePort
branch
2 times, most recently
from
January 30, 2024 16:11
8c1888f
to
e847422
Compare
mx-psi
approved these changes
Jan 31, 2024
atoulme
force-pushed
the
deprecate_testbed_GetAvailablePort
branch
from
January 31, 2024 17:14
e847422
to
2fbbf1f
Compare
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
**Description:** Deprecate testbed.GetAvailablePort in favor of testutil.GetAvailablePort Move healthcheckextension to use testutil.GetAvailablePort
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
**Description:** Deprecate testbed.GetAvailablePort in favor of testutil.GetAvailablePort Move healthcheckextension to use testutil.GetAvailablePort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
extension/healthcheck
Health Check Extension
testbed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate testbed.GetAvailablePort in favor of testutil.GetAvailablePort
Move healthcheckextension to use testutil.GetAvailablePort