[exporter/datadog] Use statswriter, client aggregator is for tracer stats only #31173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dineshg13,
liustanley,
mackjmr,
mx-psi and
songy23
ajgajg1134
changed the title
songy23
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Can you add a changelog? https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.chloggen/TEMPLATE.yaml
songy23
reviewed
Feb 9, 2024
songy23
reviewed
Feb 12, 2024
mackjmr
reviewed
Feb 12, 2024
jdgumz
reviewed
Feb 12, 2024
jdgumz
approved these changes
Feb 12, 2024
dineshg13
reviewed
Feb 13, 2024
It looks like tracer version is just an "informative" field, I ran it locally and did verify that the new code gave an empty string. So to keep the previous behavior I just added a commit that will attach the tracer version to the client stats payload if it's not already there |
mx-psi
approved these changes
Feb 14, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…tats only (open-telemetry#31173) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The `ProcessStats` function receives "tracer stats" payloads, by looping through the payload and breaking it apart this drastically increases the number of stats payloads being emitted. Instead, let's write directly to the StatsWriter, which reduces duplicated work and keeps the payload together as a single payload. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> I tested this locally with the otel example calendar app verifying stats were calculated correctly as well, the logs also showed the reduction in the number of payloads being emitted. ~TODO: I will add a test to prevent future regression~ Done! **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2024
…tats only (open-telemetry#31173) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The `ProcessStats` function receives "tracer stats" payloads, by looping through the payload and breaking it apart this drastically increases the number of stats payloads being emitted. Instead, let's write directly to the StatsWriter, which reduces duplicated work and keeps the payload together as a single payload. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> I tested this locally with the otel example calendar app verifying stats were calculated correctly as well, the logs also showed the reduction in the number of payloads being emitted. ~TODO: I will add a test to prevent future regression~ Done! **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
ProcessStatsfunction receives "tracer stats" payloads, by looping through the payload and breaking it apart this drastically increases the number of stats payloads being emitted. Instead, let's write directly to the StatsWriter, which reduces duplicated work and keeps the payload together as a single payload.Link to tracking Issue:
Testing:
I tested this locally with the otel example calendar app verifying stats were calculated correctly as well, the logs also showed the reduction in the number of payloads being emitted.
TODO: I will add a test to prevent future regressionDone!Documentation: