[k8sclusterreceiver] add k8s.container.status_last_terminated_reason metric #31281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
k8scluster/add-last-terminated-state
branch
from
db808b8
to
56932bb
Compare
crobert-1
reviewed
Feb 29, 2024
Comment on lines
+215
to
+216
| reason: | ||
| description: "the container status terminated reason" |
There was a problem hiding this comment.
If this attribute is only ever going to be used for this specific status, the name should probably be more descriptive. If it may someday be used for more statuses, the description should be more generic.
| @@ -274,6 +278,14 @@ metrics: | |||
| unit: "" | |||
| gauge: | |||
| value_type: int | |||
| k8s.container.status_last_terminated_reason: | |||
| enabled: false | |||
| description: Last terminated reason of container. The unit is always 1. | |||
There was a problem hiding this comment.
The unit is always 1.
I believe, from the other code being added, this should instead say the value will always be 1. Am I correct or do you mean something else here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding optional k8s.container.status_last_terminated_reason metric, which always has value of one if the container was terminated.
Would like to use this to track OOM kills / Evictions of pods.
Link to tracking Issue:
#31282
Testing:
Documentation: