[chore][pkg/stanza] move file handling to internal package #31506
Conversation
|
Thanks @VihasMakwana. This is on my list, just haven't found time to fully think it through yet. |
There was a problem hiding this comment.
Thanks again for working on this @VihasMakwana. I think overall this looks pretty good but I suggest a slightly different line for separating manager vs tracker responsibilities.
One thing I will call out specifically is that I think it's helpful to look at the notion of a tracker as something which will eventually have alternative implementations. So the api we establish here could be a prototype for a tracker interface. Then we can keep this implementation in place and use a feature gate to try out your async implementation. See #31534 for another example of what could be tracker implementation (which in that case would intentionally not remember files at all). Also see #31596 for a bigger picture explanation of where I think this is headed.
VihasMakwana
force-pushed
the
add-internal-pkg-tracker
branch
from
8163588
to
e920fdd
Compare
VihasMakwana
force-pushed
the
add-internal-pkg-tracker
branch
from
0571df0
to
e920fdd
Compare
|
@djaglowski the CI's green. can you take a look? |
…metry#31506) **Description:** Intrdocue a new internal package `tracker` to handle file operations.
…metry#31506) **Description:** Intrdocue a new internal package `tracker` to handle file operations.
Description: Intrdocue a new internal package
trackerto handle file operations.