[processor/deltatocumulative]: timer-based expiry #31625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RichieSams please take a look :) |
RichieSams
reviewed
Mar 6, 2024
| aggr streams.Aggregator[data.Number] | ||
| exp *streams.Expiry[data.Number] | ||
| aggr streams.Aggregator[data.Number] | ||
| stale *staleness.Staleness[data.Number] |
There was a problem hiding this comment.
minor: You could name this say, nums in preparation for having multiple. (IE for histograms, etc)
There was a problem hiding this comment.
let's do that when its needed. I'd like to experiment with the type system more if we can't just drop the datapoint narrowing on the aggregator altogether
|
Added a minor naming comment. Otherwise LGTM :) |
dmitryax
approved these changes
Mar 6, 2024
|
Thank you, @sh0rez! |
26 tasks
jpkrohling
pushed a commit
that referenced
this pull request
Mar 11, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #31488 was recently merged and has broken `build-and-test` for all builds due to a lint failure. It looks like two PRs were worked on in parallel, the aforementioned one, as well as #31625. #31625 renamed `exp` to `stale`, but the most recently merged PR was referencing the original `exp` variable. This is an unreleased component, and is simply fixing a bug, so I don't think this should have a changelog.
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Moves from complex preemptive expiry to a plain 1 minute timer **Link to tracking Issue:** open-telemetry#31615 (comment) Resolves open-telemetry#31615
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> open-telemetry#31488 was recently merged and has broken `build-and-test` for all builds due to a lint failure. It looks like two PRs were worked on in parallel, the aforementioned one, as well as open-telemetry#31625. open-telemetry#31625 renamed `exp` to `stale`, but the most recently merged PR was referencing the original `exp` variable. This is an unreleased component, and is simply fixing a bug, so I don't think this should have a changelog.
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Moves from complex preemptive expiry to a plain 1 minute timer **Link to tracking Issue:** open-telemetry#31615 (comment) Resolves open-telemetry#31615
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> open-telemetry#31488 was recently merged and has broken `build-and-test` for all builds due to a lint failure. It looks like two PRs were worked on in parallel, the aforementioned one, as well as open-telemetry#31625. open-telemetry#31625 renamed `exp` to `stale`, but the most recently merged PR was referencing the original `exp` variable. This is an unreleased component, and is simply fixing a bug, so I don't think this should have a changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Moves from complex preemptive expiry to a plain 1 minute timer
Link to tracking Issue: #31615 (comment)
Resolves #31615