Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/k8sattributes] Add support for k8s.node.uid metadata #31637

Merged
merged 1 commit into from Mar 13, 2024
Merged

[processor/k8sattributes] Add support for k8s.node.uid metadata #31637

merged 1 commit into from Mar 13, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Mar 7, 2024 •
edited

Description:

This PR adds support for including the k8s.node.uid as part of the metadata added by the processor.

Link to tracking Issue:

Testing:
TestAddNodeUID

Documentation:
Updated README.md

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Mar 7, 2024
@ChrsMark ChrsMark marked this pull request as ready for review March 7, 2024 14:57
@ChrsMark ChrsMark requested a review from a team as a code owner March 7, 2024 14:57
@ChrsMark ChrsMark force-pushed the add_node_uid_k8s_attrib branch 2 times, most recently from 674e6ba to 9328173 Compare March 7, 2024 15:02
dmitryax
dmitryax approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark please rebase

@ChrsMark
[processor/k8sattributes] Add support for k8s.node.uid metadata
67a140e 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

@ChrsMark please rebase

Thank's! Done.

@fatsheep9146 fatsheep9146 added the ready to merge Code review completed; ready to merge by maintainers label Mar 13, 2024
@TylerHelmuth TylerHelmuth merged commit 4700e4b into open-telemetry:main Mar 13, 2024
147 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 13, 2024
@ChrsMark ChrsMark deleted the add_node_uid_k8s_attrib branch April 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@rmfitzpatrick rmfitzpatrick Awaiting requested review from rmfitzpatrick

Assignees

@dmitryax dmitryax

Labels
processor/k8sattributes k8s Attributes processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrsMark @dmitryax @fatsheep9146 @TylerHelmuth