[connector/datadog] Remove feature gate connector.datadogconnector.performance #31638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Mar 7, 2024
|
@songy23, this appears to have broken windows tests: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8190945099 Should we revert or do you think it's a quick fix? |
|
That's surprising as this feature gate is no longer used anywhere now. We can revert for now, I'll take a look at the test failure |
|
Hmm, might be unrelated. I didn't look into it much, just saw it was a failure in the same component. |
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ector.performance" (open-telemetry#31639) Reverts open-telemetry#31638
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ector.performance" (open-telemetry#31639) Reverts open-telemetry#31638
mx-psi
added a commit
that referenced
this pull request
Mar 15, 2024
…rformance (#31770) This restores #31638. #31638 was reverted initially because we thought it led to #31663, but it turns out #31663 is still happening without #31638 so it is probably a different issue. It should be safe to roll forward #31638. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.