WIP - Update pkg/stanza operators to use component package types #31664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I'll iterate on this some more in the near future to simplify further, then break down the PR into smaller items which can be addressed. |
35 tasks
|
Closing as my refactoring is looking like a dead end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #31618
The original motivation for this work is to support
component.TelemetrySettings. While attempting to implement this in a non-breaking way, I found I was essentially reworking the API for for building operators. Ultimately, I found that types and patterns defined in thecomponentpackage are broadly useful here as well. The scope of the PR is far too large but I want to prove out the approach and seek early feedback.Currently there is still at least one test failures which I need to work through, and then many lint failures due to use of deprecated functions. I plan to get these working in order to prove out the changes. Then I'll start breaking off incremental PRs.