HTTP forwarder should not report ErrServerClosed #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcamp
approved these changes
Apr 19, 2021
|
Please rebase |
pjanotti
force-pushed
the
httpforwarder_no_err_on_close
branch
from
4d902f3
to
a7aaf29
Compare
Codecov Report
@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
- Coverage 91.93% 91.92% -0.02%
==========================================
Files 493 493
Lines 23936 23936
==========================================
- Hits 22006 22002 -4
- Misses 1426 1428 +2
- Partials 504 506 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.23.0...v0.24.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP forwarder reports ErrServerClosed when shutting down the service. This error is expected and should not be reported.