Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[chore][receiver/sqlquery] Enable goleak check (#31667)" #31783

Closed
wants to merge 1 commit into from
Closed

Revert "[chore][receiver/sqlquery] Enable goleak check (#31667)" #31783

wants to merge 1 commit into from

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Mar 15, 2024 •
edited

This reverts commit 2a638ec.

Related to #31782

@github-actions github-actions bot added the receiver/sqlquery SQL query receiver label Mar 15, 2024
@TylerHelmuth
Copy link
Member Author

You can see here we get the green check again: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8301487694/job/22721741052?pr=31783

image

@TylerHelmuth TylerHelmuth marked this pull request as ready for review March 15, 2024 19:48
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner March 15, 2024 19:48
@TylerHelmuth TylerHelmuth marked this pull request as draft March 15, 2024 19:56
@TylerHelmuth
Copy link
Member Author

Something is still fishy, I need to keep investigating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@codeboten codeboten

Labels
receiver/sqlquery SQL query receiver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TylerHelmuth @codeboten