Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/signalfx] add a few more default excluded metrics to exporter #3207

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

mstumpfx
Copy link

These metrics are being categorized as custom metrics in our backend, so we should not emit them unless explicitly configured to do so.

@mstumpfx mstumpfx requested a review from a team as a code owner April 22, 2021 15:24
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #3207 (6b60006) into main (c98d8ae) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
- Coverage   91.93%   91.90%   -0.03%     
==========================================
  Files         493      493              
  Lines       23918    23918              
==========================================
- Hits        21988    21982       -6     
- Misses       1426     1429       +3     
- Partials      504      507       +3     
Flag Coverage Δ
integration 63.81% <ø> (+0.05%) ⬆️
unit 90.92% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/dimensions/requests.go 82.35% <0.00%> (-9.81%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98d8ae...6b60006. Read the comment docs.

@bogdandrutu
Copy link
Member

/cc @jrcamp

@bogdandrutu bogdandrutu merged commit 13b7759 into open-telemetry:main Apr 22, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants