Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/receivercreator] Log errors on receiver start/stop failures #3208

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Apr 22, 2021

Searched for other calls to logger.Error without including err.

Searched for other calls to logger.Error without including err.
@jrcamp jrcamp requested a review from bogdandrutu April 22, 2021 16:50
@jrcamp jrcamp requested a review from a team as a code owner April 22, 2021 16:50
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #3208 (bb1d823) into main (f56f902) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3208   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         494      494           
  Lines       23962    23962           
=======================================
  Hits        22028    22028           
  Misses       1428     1428           
  Partials      506      506           
Flag Coverage Δ
integration 63.68% <ø> (ø)
unit 90.94% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/receivercreator/observerhandler.go 67.18% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56f902...bb1d823. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 3dbcb25 into open-telemetry:main Apr 22, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
…open-telemetry#3208)

Searched for other calls to logger.Error without including err.
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
…open-telemetry#3208)

Searched for other calls to logger.Error without including err.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants