Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API key detection logic. #3212

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

a-feld
Copy link
Member

@a-feld a-feld commented Apr 22, 2021

Description: Updates key detection logic for New Relic

Testing: Unit tests updated.

@a-feld a-feld marked this pull request as ready for review April 22, 2021 21:49
@a-feld a-feld requested a review from a team as a code owner April 22, 2021 21:49
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #3212 (af704f6) into main (3dbcb25) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3212   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         494      494           
  Lines       23947    23947           
=======================================
  Hits        22011    22011           
  Misses       1429     1429           
  Partials      507      507           
Flag Coverage Δ
integration 63.68% <ø> (+0.21%) ⬆️
unit 90.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/newrelicexporter/newrelic.go 96.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbcb25...af704f6. Read the comment docs.

@a-feld
Copy link
Member Author

a-feld commented Apr 23, 2021

@bogdandrutu this is ready to merge 😄

@bogdandrutu bogdandrutu merged commit d37dc81 into open-telemetry:main Apr 23, 2021
@nrcventura nrcventura deleted the update-nr-api-keys branch April 23, 2021 21:17
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants