-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][receiver/sqlserver] Add direct connection config options #32176
[chore][receiver/sqlserver] Add direct connection config options #32176
Conversation
503e64d
to
e23c18f
Compare
…n-telemetry#32176) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This adds config options for direct connection to a SQL server instance. For the sake of PR size, this adds no functionality, it's simply config options and validation. **Link to tracking Issue:** <Issue number if applicable> This was originally part of open-telemetry#31915, but I'm breaking this out to make the original PR a more manageable size. open-telemetry#30297 **Testing:** <Describe what testing was performed and which tests were added.> Existing tests and added tests are all passing. **Documentation:** <Describe the documentation added.> No documentation on purpose. The added config options currently have no impact on functionality, so users shouldn't be aware of this, and shouldn't try to use them yet.
Is Windows Auth supported? |
You're wondering if these configuration options are available on Windows? If so, yes they are. |
Not quite, I'm wondering if we can use windows authentication as opposed to username/password hardcoded in the config. We run the opentelemetry collector as a windows service, and as such there is a service account associated with the opentelemetry collector. We can grant the service account access to the database, and if Windows Authentication is supported then the collector could make a query without needing a username/password combo. |
I don't believe that's supported currently, but you're welcome to open an issue to request it 👍 |
😃 #32986 |
Description:
This adds config options for direct connection to a SQL server instance. For the sake of PR size, this adds no functionality, it's simply config options and validation.
Link to tracking Issue:
This was originally part of #31915, but I'm breaking this out to make the original PR a more manageable size.
#30297
Testing:
Existing tests and added tests are all passing.
Documentation:
No documentation on purpose. The added config options currently have no impact on functionality, so users shouldn't be aware of this, and shouldn't try to use them yet.