[pkg/stanza] Add send_quiet/drop_quiet options for on_error setting
#32220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverOrion
reviewed
Apr 12, 2024
pkg/stanza/docs/types/on_error.md
Outdated
| @@ -1,10 +1,21 @@ | |||
| # `on_error` parameter | |||
| The `on_error` parameter determines the error handling strategy an operator should use when it fails to process an entry. There are 2 supported values: `drop` and `send`. | |||
| The `on_error` parameter determines the error handling strategy an operator should use when it fails to | |||
| process an entry. There are 2 supported values: `drop` and `send`. | |||
There was a problem hiding this comment.
Suggested change
| process an entry. There are 2 supported values: `drop` and `send`. | |
| process an entry. There are 4 supported values: `drop`, `send`, `send_quiet`, and `drop_quiet`. |
pkg/stanza/docs/types/on_error.md
Outdated
| operators are defined which might flood the logs with errors. | ||
|
|
||
| ### `drop_quiet` |
There was a problem hiding this comment.
[nit]
How about the following order?
dropdrop_quietsendsend_quiet
When stanza operators fail to process a message, no matter if they send the message or drop it an error message is logged. This can be quite "noisy" when users want to set up a best effort operator which on error should only send/drop the message without logging an error. With introducing the send_quiet and drop_quiet options we provide the option to set the level of the logged error. send_quiet and drop_quiet will log the error on debug level. Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
mute_op_errors
branch
from
5bdbd54
to
be06c10
Compare
djaglowski
approved these changes
Apr 15, 2024
LokeshOpsramp
pushed a commit
to opsramp/opentelemetry-collector-contrib
that referenced
this pull request
May 5, 2024
…ng (open-telemetry#32220) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When stanza operators fail to process a message, no matter if they send the message or drop it an error message is logged. This can be quite "noisy" when users want to set up a best effort operator which on error should only send/drop the message without logging an error. With introducing the `send_quiet` and `drop_quiet` options we provide the option to set the level of the logged error. `send_quiet` and `drop_quiet` log the error on debug level. **Link to tracking Issue:** open-telemetry#32145 **Testing:** <Describe what testing was performed and which tests were added.> Added [unit-tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32220/files#diff-6a03331b322fcfd255ead096ac5c7c9dd9267a2d6697ea629548f37f4049896aR70) **Documentation:** <Describe the documentation added.> [Enhanced the operator's docs](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32220/files#diff-8f730eb2d61d9ca8c5cf863e9e7f3ddfe51984c46c6259dd7258902d6cc10090L2) --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…ng (open-telemetry#32220) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When stanza operators fail to process a message, no matter if they send the message or drop it an error message is logged. This can be quite "noisy" when users want to set up a best effort operator which on error should only send/drop the message without logging an error. With introducing the `send_quiet` and `drop_quiet` options we provide the option to set the level of the logged error. `send_quiet` and `drop_quiet` log the error on debug level. **Link to tracking Issue:** open-telemetry#32145 **Testing:** <Describe what testing was performed and which tests were added.> Added [unit-tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32220/files#diff-6a03331b322fcfd255ead096ac5c7c9dd9267a2d6697ea629548f37f4049896aR70) **Documentation:** <Describe the documentation added.> [Enhanced the operator's docs](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32220/files#diff-8f730eb2d61d9ca8c5cf863e9e7f3ddfe51984c46c6259dd7258902d6cc10090L2) --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When stanza operators fail to process a message, no matter if they send the message or drop it an error message is logged. This can be quite "noisy" when users want to set up a best effort operator which on error should only send/drop the message without logging an error.
With introducing the
send_quietanddrop_quietoptions we provide the option to set the level of the logged error.send_quietanddrop_quietlog the error on debug level.Link to tracking Issue: #32145
Testing: Added unit-tests
Documentation: Enhanced the operator's docs