[exporter/datadog] Refactor Datadog Exporter to use logs agent exporter #32327
Conversation
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
dineshg13,
dmitryax,
mackjmr,
mx-psi and
songy23
There was a problem hiding this comment.
We probably need to support a few logs agent configs, e.g. https://github.com/DataDog/datadog-agent/blob/main/pkg/config/config_template.yaml#L1281 & https://github.com/DataDog/datadog-agent/blob/main/pkg/config/config_template.yaml#L1244
Can be done in follow-up PRs
| Config: cfgComponent, | ||
| Hostname: hostnameComponent, | ||
| }) | ||
| err = logsAgent.Start(ctx) |
There was a problem hiding this comment.
We are starting the logsAgent during component creation time. We should not do this, that's what exporterhelper.WithStart is used for
There was a problem hiding this comment.
logsAgent.Start also sets up the pipeline channel that gets passed into the logsAgentExporter, and logsAgentExporter.ConsumeLogs gets passed into the exporterhelper at the end of createLogsExporter. Is there a way to set this all up while also using exporterhelper.WithStart? I don't think we follow this pattern elsewhere in the datadog exporter
There was a problem hiding this comment.
Hm, so this has come up recently on open-telemetry/opentelemetry-collector/issues/10031. It's true that there are other things doing the wrong thing in our exporter, I will file a ticket for those. If we can solve this problem now for this one though it would be great not to make the problem worse.
| Config: cfgComponent, | ||
| Hostname: hostnameComponent, | ||
| }) | ||
| err = logsAgent.Start(ctx) |
There was a problem hiding this comment.
Hm, so this has come up recently on open-telemetry/opentelemetry-collector/issues/10031. It's true that there are other things doing the wrong thing in our exporter, I will file a ticket for those. If we can solve this problem now for this one though it would be great not to make the problem worse.
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…er (open-telemetry#32327) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds support for the logs agent exporter in order to export logs to Datadog. The following changes were made in order to support this: - Update datadog-agent modules to the following commit hash version: DataDog/datadog-agent@a1ef7ed - Remove `peer_service_aggregation` config option which was deprecated and removed since last datadog-agent version: DataDog/datadog-agent#23284 - Add logs agent exporter setup in datadog exporter factory. This is disabled by default and can be enabled via feature gate. **Link to tracking Issue:** Fixes open-telemetry#30099 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…er (open-telemetry#32327) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds support for the logs agent exporter in order to export logs to Datadog. The following changes were made in order to support this: - Update datadog-agent modules to the following commit hash version: DataDog/datadog-agent@a1ef7ed - Remove `peer_service_aggregation` config option which was deprecated and removed since last datadog-agent version: DataDog/datadog-agent#23284 - Add logs agent exporter setup in datadog exporter factory. This is disabled by default and can be enabled via feature gate. **Link to tracking Issue:** Fixes open-telemetry#30099 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Description:
This PR adds support for the logs agent exporter in order to export logs to Datadog. The following changes were made in order to support this:
peer_service_aggregationconfig option which was deprecated and removed since last datadog-agent version: apm: rm deprecated peer_service_aggregation config DataDog/datadog-agent#23284Link to tracking Issue:
Fixes #30099
Testing:
Documentation: