-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscontainerinsight] Fix memory leak on shutdown in k8s API server #32405
base: main
Are you sure you want to change the base?
[receiver/awscontainerinsight] Fix memory leak on shutdown in k8s API server #32405
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
nicely ping @Aneurysm9 for review |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@Aneurysm9 please review |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging code owners @Aneurysm9 @pxaws
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description:
This change has 4 main parts:
Shutdown
as it has its own running goroutines that need shutdown to avoid leaking.Shutdown
in the failure scenarios ofNew
. This is required because once again, goroutines are started during the k8s API server'sNew
call stack. Since it returnsnil
on error, there's no way to shutdown once it returns. This meansShutdown
must be called on error.goleak
checks to help ensure no goroutines are being leaked.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleak
checks.