Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka/internal, kafkaexporter, kafkareceiver] Add SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter #32500

Conversation

donald-cheung
Copy link

@donald-cheung donald-cheung commented Apr 18, 2024

Description:
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL Signer for Go https://github.com/aws/aws-msk-iam-sasl-signer-go. This mechanism is added because the "AWS_MSK_IAM" is not working in our cluster and also in this issue. We added an new mechanism instead of replace the existing one because we want to keep the backward compatibility just in case someone is using "AWS_MSK_IAM".

Link to tracking Issue:
19747

Testing:
We built the images and tested the SASL mechanism in our team.
We added related unit tests.

Documentation:
We updated the kafkaexporter and kafakreciever README on the SASL mechanism.

Copy link

linux-foundation-easycla bot commented Apr 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

github-actions bot commented May 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 2, 2024
@mx-psi
Copy link
Member

mx-psi commented May 2, 2024

@donald-cheung Thanks for your contribution! We need to you to sign the CLA in order to be able to accept your contribution

@github-actions github-actions bot removed the Stale label May 3, 2024
@donald-cheung
Copy link
Author

@mx-psi
Thanks for the reminder. I am asking my company to sign the CCLA so it will take some time.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 21, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 4, 2024
@mattiasnensen
Copy link

Hey, this would be awesome to have. What's going on?

@donald-cheung
Copy link
Author

Sorry, we are in the process of getting approval from the upper organization. This will take some time. Thank you.

@donald-cheung
Copy link
Author

We will have a meeting and update the progress next week.
BTW, how can I reopen this PR? There is no button in the bottom. Thank you.

@mx-psi
Copy link
Member

mx-psi commented Jun 6, 2024

@donald-cheung Let me know when you have approval from your org and want to reopen the PR and I can do it for you :)

@donald-cheung
Copy link
Author

@mx-psi Thanks. The meeting is rescheduled to next week so I will update you later.

@canhnt
Copy link
Contributor

canhnt commented Jun 20, 2024

Hi @donald-cheung, could you please keep posted on the result? This MR is useful for us.

@donald-cheung
Copy link
Author

Sorry for the late reply. The feedback from the upper organization is good. The upper organization will start their procedures to approve.

@jnavarro86
Copy link

@donald-cheung I just tested it and it is working for me, Thanks.

@donald-cheung
Copy link
Author

donald-cheung commented Jul 23, 2024

@mx-psi @MovieStoreGuy
May you reopen the PR please? My organization will sign the CLA and I will fix the merge conflict. Thank you.

@donald-cheung
Copy link
Author

@mx-psi, @MovieStoreGuy, @dmitryax Thank you for waiting. The CLA is signed.

@donald-cheung
Copy link
Author

@mx-psi, @MovieStoreGuy, @dmitryax. Is there update on reopening this PR? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants