-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kafka/internal, kafkaexporter, kafkareceiver] Add SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter #32500
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@donald-cheung Thanks for your contribution! We need to you to sign the CLA in order to be able to accept your contribution |
@mx-psi |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Hey, this would be awesome to have. What's going on? |
Sorry, we are in the process of getting approval from the upper organization. This will take some time. Thank you. |
We will have a meeting and update the progress next week. |
@donald-cheung Let me know when you have approval from your org and want to reopen the PR and I can do it for you :) |
@mx-psi Thanks. The meeting is rescheduled to next week so I will update you later. |
Hi @donald-cheung, could you please keep posted on the result? This MR is useful for us. |
Sorry for the late reply. The feedback from the upper organization is good. The upper organization will start their procedures to approve. |
@donald-cheung I just tested it and it is working for me, Thanks. |
@mx-psi @MovieStoreGuy |
@mx-psi, @MovieStoreGuy, @dmitryax Thank you for waiting. The CLA is signed. |
@mx-psi, @MovieStoreGuy, @dmitryax. Is there update on reopening this PR? Thank you. |
Description:
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL Signer for Go https://github.com/aws/aws-msk-iam-sasl-signer-go. This mechanism is added because the "AWS_MSK_IAM" is not working in our cluster and also in this issue. We added an new mechanism instead of replace the existing one because we want to keep the backward compatibility just in case someone is using "AWS_MSK_IAM".
Link to tracking Issue:
19747
Testing:
We built the images and tested the SASL mechanism in our team.
We added related unit tests.
Documentation:
We updated the kafkaexporter and kafakreciever README on the SASL mechanism.