[StatsD receiver] Add timing/histogram for statsD receiver as OTLP summary #3261
Conversation
gavindoudou
changed the title
|
@jmacd can you review this? |
| `"observer_type"` specifies OTLP data type to convert to. The only supported target data type currently is `"gauge"`, which does not perform any aggregation. | ||
| Support for `"summary"` data type is planned to be added in the future. | ||
| `"observer_type"` specifies OTLP data type to convert to. We support `"gauge"` and `"summary"`. For `"gauge"`, it does not perform any aggregation. | ||
| For `"summary`, the statsD receiver will aggregate to one OTLP summary metric for one metric description(the same metric name with the same tags). It will send percentile 0, 10, 50, 90, 95, 100 to the downstream. |
There was a problem hiding this comment.
Are the quantiles configurable?
There was a problem hiding this comment.
The quantiles are fixed.
|
Question: The use of In a Prometheus setting, the Summary metric uses a smoothed calculation that covers 5-10minutes of state, so that even when a small number of points arrive in each interval, the numbers are relatively table. I wonder about a TODO or an option to use the Prometheus Summary logic directly, though it will mean a bit of investigation to see if it can be extracted from Thanks! |
|
Do you mean we could have different aggregation intervals for summary and others? |
|
The Prometheus Summary uses https://github.com/beorn7/perks/tree/master/quantile. I wasn't suggesting to change the interval, but suppose there is a 10 second interval. Using a smoothed summary means that every 10 seconds we'll output the summary values averaged over the last 5 minutes or so. I don't want you to change this PR, and happy if it remains a TODO, but I think that will be more useful to the users. |
|
Oh, I see. Added a TODO in |
gavindoudou
force-pushed
the
statsDSummaryTimer
branch
from
869d8fa
to
2c2d70f
Compare
gavindoudou
force-pushed
the
statsDSummaryTimer
branch
from
2c2d70f
to
f60ba47
Compare
* remove unnecessary functions * rename functions * update
Description:
msorhStatsD type and transfers to OTLP summary. The receiver will aggregate in each interval and transfer the float array(with all values) to a OTLP summary metric.For example: the receiver receives in one interval:
statsdTestMetric2:2|ms|#mykey:myvalue
statsdTestMetric2:2|ms|#mykey:myvalue
statsdTestMetric2:5|ms|#mykey:myvalue
statsdTestMetric2:6|ms|#mykey:myvalue
It will generate a OTLP summary metric with percentile 0, 10, 50, 90, 95, 100.
matchin previous PR's config since we don't have regex support yet. Discussed with Josh and Tigran about it. They both agreed to remove math.Link to tracking Issue:
#2566
previous PR: #2973
Testing:
Added unit tests
Documentation: