New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/telemetrygen: Add headers to gRPC metadata for logs #32668
Merged
mx-psi
merged 2 commits into
open-telemetry:main
from
metalmatze:telemetrygen-logs-grpc-metadata
Apr 25, 2024
Merged
cmd/telemetrygen: Add headers to gRPC metadata for logs #32668
mx-psi
merged 2 commits into
open-telemetry:main
from
metalmatze:telemetrygen-logs-grpc-metadata
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reopening, LGTM!
metalmatze
force-pushed
the
telemetrygen-logs-grpc-metadata
branch
from
April 24, 2024 14:05
f6308ce
to
d796638
Compare
Rebased against the latest |
metalmatze
force-pushed
the
telemetrygen-logs-grpc-metadata
branch
from
April 24, 2024 15:38
d796638
to
f528611
Compare
songy23
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
and removed
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Apr 24, 2024
songy23
approved these changes
Apr 24, 2024
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…ry#32668) **Description:** <Describe what has changed.> So far, sending (HTTP) headers along with gRPC requests hasn't been possible. For that reason, sending bearer tokens for authentication didn't work either. This is fixed now. Updated version of open-telemetry#30082 cc @mx-psi --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
jlg-io
pushed a commit
to jlg-io/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
…ry#32668) **Description:** <Describe what has changed.> So far, sending (HTTP) headers along with gRPC requests hasn't been possible. For that reason, sending bearer tokens for authentication didn't work either. This is fixed now. Updated version of open-telemetry#30082 cc @mx-psi --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
So far, sending (HTTP) headers along with gRPC requests hasn't been possible.
For that reason, sending bearer tokens for authentication didn't work either.
This is fixed now.
Updated version of #30082
cc @mx-psi